Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programme script ux improvements #26

Merged
merged 7 commits into from
Mar 5, 2020
Merged

Conversation

pietrop
Copy link
Owner

@pietrop pietrop commented Mar 5, 2020

Is your Pull Request request related to another issue in this repository ?

building off changes from #25
Describe what the PR does

Adds a contextual menu in between "paper-cuts" in a programme script.
For now to add

  • header title
  • notes
  • voice over

better-insert

  • select text in transcript, use contextual menu to paste the selection

better-insert-2

State whether the PR is ready for review or whether it needs extra work

Done
Additional context

Inspired by gitbooks, but unlike gitbooks you can click anywhere on the line, rather then just on the x

  • Handle what happens when you click cancel

could remove + Selection btn and the dropdown to add Voice over, notes, and headings but leaving in for now, might remove in future releases...

@pietrop pietrop merged commit 82192c8 into master Mar 5, 2020
@pietrop pietrop deleted the programme-script-ux-improvements branch March 5, 2020 04:54
@pietrop
Copy link
Owner Author

pietrop commented Mar 5, 2020

Doesn't fully work in demo mode, coz it require saving to complete the operation but here it is https://pietropassarelli.com/digital-paper-edit-client/#/projects/10046281c4ad4938b7d0ae6fa9899bec/paperedits/86e938c468de4b0cb873c6e97a3a25f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant