Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate/remove nbPostInit #50

Closed
pietroppeter opened this issue May 27, 2021 · 0 comments · Fixed by #61
Closed

deprecate/remove nbPostInit #50

pietroppeter opened this issue May 27, 2021 · 0 comments · Fixed by #61

Comments

@pietroppeter
Copy link
Owner

it did not look like a good idea from the beginning, but it proved to be really bad: pietroppeter/nimibook#8
The alternative mechanism should be something like #45 or pietroppeter/nimibook#15
@pietroppeter pietroppeter mentioned this issue Jun 24, 2021
Merged
5 tasks
pietroppeter added a commit that referenced this issue Nov 6, 2021
@pietroppeter
nb refactor (fix #25) + new paths (fix #55) + fix #50, #51 (#61)
df345bc 
* instead of creating and injecting multiple variables
  (`nbDoc`, `nbBlock`, `nbHomeDir`, ...), nimib now only injects a `nb` variable
  that is a `NbDoc`. Some aliases are provided to minimize breakage.
* handling of paths (`srcDir` and `homeDir`) is changed and is based on the presence
  of a new config file `nimib.toml`
* command line options are now processed and can be used to skip/override the config process.
  Run any nimib file with option `--nbHelp` to see available options.
* `nbPostInit` and `nbPreSave` customization mechanism based on includes are now removed 
* added `nbShow` command option to open in browser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nb refactor (fix #25) + new paths (fix #55) + fix #50, #51 pietroppeter/nimib
1 participant
@pietroppeter