Fix usebruno#1683 allow OAuth2 authorizationUrl with user provided pa…

…rameters
pietrygamat · Mar 2, 2024 · 00b9dd5 · 00b9dd5
1 parent 9d3df0a
commit 00b9dd5
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/bruno-electron/src/ipc/network/oauth2-authorization-code-helper.js b/packages/bruno-electron/src/ipc/network/oauth2-authorization-code-helper.js
@@ -25,7 +25,10 @@ const getOAuth2AuthorizationCode = (request) => {
   return new Promise(async (resolve, reject) => {
     const { oauth2 } = request;
     const { callbackUrl, clientId, authorizationUrl, scope } = oauth2;
-    const authorizationUrlWithQueryParams = `${authorizationUrl}?client_id=${clientId}&redirect_uri=${callbackUrl}&response_type=code&scope=${scope}`;
+    const authorizationUrlWithQueryParams =
+      `${authorizationUrl}` +
+      (authorizationUrl.indexOf('?') > -1 ? '&' : '?') +
+      `client_id=${clientId}&redirect_uri=${callbackUrl}&response_type=code&scope=${scope}`;
     try {
       const code = await authorizeUserInWindow({ authorizeUrl: authorizationUrlWithQueryParams, callbackUrl });
       resolve(code);