Option to ignore missing props on params #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This library is awesome and a cornerstone of all our data access. However, one thing we've continually found ourselves wishing for is the ability to ignore missing params and supply PG with a null value. This is a crud example, written in the Github editor, but feels like it'd cover most of what we'd like to see. We don't use any of the file scanning, so would love some feedback and direction on how this could be written to make it into core. Happy to write tests / docs as needed. Thanks for the great OSS contribution :)
|
Thanks for your kind words, nice to hear there is use for this lib! The solution looks like a good approach. So the idea would be to call some SQL statement with less parameters than in the statement and then insert NULL for the missing parameters. Maybe the config property name would be better then to be "useNullOnMissing". Then the solution would need to make sure it works on SQLite MySQL/Maria and Postgres. I can start working on this. Tests and docs are also very welcome. |
|
Well this took a while, sorry.. fortunately the holidays came :) This is now available in version 4.1.0 wiyh flag "useNullForMissing" |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library is awesome and a cornerstone of all our data access. However, one thing we've continually found ourselves wishing for is the ability to ignore missing params and supply PG with a null value.
This is a crud example, written in the Github editor, but feels like it'd cover most of what we'd like to see. We don't use any of the file scanning, so would love some feedback and direction on how this could be written to make it into core. Happy to write tests / docs as needed.
Thanks for the great OSS contribution :)