Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new option 'strict' that will throw if name already exist #26

Closed
wants to merge 1 commit into from
Closed

Conversation

asafyish
Copy link

@asafyish asafyish commented Nov 4, 2020

I don't want to break existing behaviour, so making this strict option as optional. I think that in future versions it should be the default.

@pihvi
Copy link
Owner

pihvi commented Dec 11, 2020

I thought this is such an important feature, that released a new major version 5.0.0 with this as default behaviour.
Is this working for you as intended?

Thanks again!

closes #25

@pihvi pihvi closed this Dec 11, 2020
@asafyish
Copy link
Author

Yes that's great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants