Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Feature Request 1088 #1625

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vinnyfuria
Copy link

Description

Implementation of #1088. Specifically:

  1. Added current humidity to state info
  2. Added status badge to indicate if humidifier is idle or not

Related Issue

This PR fixes or closes issue: fixes #1088

Motivation and Context

Makes the humidifier card match features with climate card providing more information to users.

How Has This Been Tested

Tested locally following "developer" instructions.

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚙️ Tech (code style improvement, performance improvement or dependencies bump)
  • 📚 Documentation (fix or addition in the documentation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.
  • I followed the steps if I add a new language .

1. Added current humidity to state info
2. Added status badge to indicate if humidifier is idle or not
Copy link

@mxr mxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable but I haven't tested on my end

src/cards/humidifier-card/humidifier-card.ts Outdated Show resolved Hide resolved
src/cards/humidifier-card/humidifier-card.ts Outdated Show resolved Hide resolved
src/cards/humidifier-card/humidifier-card.ts Outdated Show resolved Hide resolved
src/cards/humidifier-card/humidifier-card.ts Show resolved Hide resolved
Mostly removing unneeded code and improving readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Show current humidity level in humidifier card
2 participants