Allow to pass time limit to SLURM, further minor adaptations #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardarosemann
force-pushed
the
set-time-limit
branch
from
8493ed4 to
cafac7c
Compare
ricardarosemann
force-pushed
the
set-time-limit
branch
from
cafac7c to
c94d3df
Compare
robinhasse
approved these changes
Sep 30, 2024
R/findLastRun.R
Outdated
| @@ -12,7 +12,7 @@ findLastRun <- function(outputFolder) { | |||
|
|
|||
| if (dir.exists(outputFolder)) { | |||
| regexStamp <- "\\d{4}-\\d{2}-\\d{2}_\\d{2}\\.\\d{2}\\.\\d{2}" | |||
| paths <- list.files(outputFolder, pattern = regexStamp, all.files = TRUE) | |||
| paths <- list.files(outputFolder, pattern = paste0(regexStamp, "$"), all.files = TRUE) | |||
There was a problem hiding this comment.
We could limit this to directories explicitly, right?
Suggested change
| paths <- list.files(outputFolder, pattern = paste0(regexStamp, "$"), all.files = TRUE) | |
| paths <- list.dirs(outputFolder, recursive = FALSE) | |
| paths <- grep(paste0(regexStamp, "$"), paths, value = TRUE) |
There was a problem hiding this comment.
That's actually similar to how you implemented a similar functionality in the old restart-Function. But I do find it clearer, so I will adopt it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collects some very minor changes:
findLastRun: The function now ignores files when searching for the latest run folder (as long as the file has some sort of file name ending - the criterion is that the time stamp is at the very end of the file/directory name)Closes #54 .