Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECEMF mapping - adding electricity hydrogen capital cost and fixing efficiency mapping #211

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ECEMF mapping - adding electricity hydrogen capital cost and fixing efficiency mapping #211

wants to merge 2 commits into from

Conversation

Renato-Rodrigues
Copy link
Member

Purpose of this PR

  • add report for electricity|hydrogen capital cost
  • fix hydrogen|electricity efficiency mapping

@Renato-Rodrigues
Copy link
Member Author

@fbenke-pik
The lucode2 buildLIbrary function added changes to the check.yaml file that are not related with my pull request.
It is ok if I merge the PR as is, or should I revert the changes to this file before?

@fbenke-pik
Copy link
Collaborator

I think this is our standard way to disseminate changes to these yaml files. So yes, anything generated by lucode in you PR is fine and should be added.

@orichters
Copy link
Contributor

FYI: The mappings are now found at inst/mappings/mapping_ECEMF.csv because the whole package suffered from confusion what a template and a mapping is.

@orichters
Copy link
Contributor

@Renato-Rodrigues: What is the state of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbenke-pik fbenke-pik fbenke-pik approved these changes

@robertpietzcker robertpietzcker Awaiting requested review from robertpietzcker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Renato-Rodrigues @fbenke-pik @orichters