Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fmt/core.h includes #1026

Closed
msimberg opened this issue Feb 9, 2024 · 0 comments · Fixed by #1075
Closed

Update fmt/core.h includes #1026

msimberg opened this issue Feb 9, 2024 · 0 comments · Fixed by #1075
Assignees
@msimberg
Labels
effort: 2 A few hours of work. priority: medium This should be done sooner or later. type: cleanup
Milestone
0.24.0

Comments

@msimberg
Copy link
Contributor

msimberg commented Feb 9, 2024

On latest fmt master the fmt/core.h include has been deprecated and the recommended replacement is either fmt/base.h or fmt/format.h. Figure out which one to use and if the same updated includes can be used all the way back to fmt version 9.
@msimberg msimberg added effort: 2 A few hours of work. priority: medium This should be done sooner or later. type: cleanup labels Feb 9, 2024
@msimberg msimberg added this to the 0.24.0 milestone Mar 14, 2024
@msimberg msimberg moved this from Backlog to Todo in pika planning board Mar 14, 2024
@msimberg msimberg mentioned this issue Mar 18, 2024
Merged
@msimberg msimberg self-assigned this Mar 18, 2024
@msimberg msimberg moved this from Todo to In Progress in pika planning board Mar 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in pika planning board Apr 11, 2024
@aurianer aurianer moved this from Done to Archive in pika planning board Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msimberg msimberg

Labels
effort: 2 A few hours of work. priority: medium This should be done sooner or later. type: cleanup
Projects
pika planning board
Status: Archive
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

Replace includes of fmt/core.h with fmt/base.h msimberg/pika
1 participant
@msimberg