Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace includes of fmt/core.h with fmt/base.h #1075

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Replace includes of fmt/core.h with fmt/base.h #1075

merged 1 commit into from
Apr 11, 2024

Conversation

msimberg
Copy link
Contributor

Fix #1026.

Current fmt master has deprecated fmt/core.h in favour of fmt/base.h or fmt/format.h (https://github.com/fmtlib/fmt/blob/12acd7988b5eef3df060f321f61982221ec45d26/include/fmt/core.h). I've updated includes of fmt/core.h to use fmt/base.h if the latter is available (with __has_include). In cases where fmt/format.h is anyway included I've simply removed the fmt/core.h include.

@msimberg msimberg self-assigned this Mar 18, 2024
@msimberg msimberg added this to the 0.24.0 milestone Mar 18, 2024
@msimberg msimberg enabled auto-merge March 19, 2024 16:39
@msimberg msimberg added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2024
@msimberg msimberg added this pull request to the merge queue Mar 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2024
@msimberg msimberg enabled auto-merge April 8, 2024 10:30
@msimberg msimberg added this pull request to the merge queue Apr 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2024
@msimberg msimberg modified the milestones: 0.24.0, 0.25.0 Apr 11, 2024
@msimberg msimberg added this pull request to the merge queue Apr 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 11, 2024
@msimberg msimberg merged commit 023afa1 into pika-org:main Apr 11, 2024
37 of 38 checks passed
@msimberg msimberg deleted the fmt-base branch April 15, 2024 11:20
@msimberg msimberg modified the milestones: 0.25.0, 0.24.0 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer Awaiting requested review from aurianer aurianer is a code owner

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Status: Archive
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

Update fmt/core.h includes
1 participant
@msimberg