Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add santis runner pipeline #1025

Merged
merged 6 commits into from
Mar 8, 2024

Conversation

aurianer
Copy link
Contributor

@aurianer aurianer commented Feb 8, 2024

This PR uses the fact that variables gets overriden by the latest one of the same name. So the .container-builder-cscs-gh200 is the one setting the latest tag. See the tag in one of the first pipeline of this PR, it is set to santis-container-builder.
I originally tried set the container builder in a gitlab variable and then use the variable in a extend but the variable was not expanded (cf the first job).
I also tried to set the container builder extends clause at the latest possible, but it was complaining when I was removing it from the template job.

Note: it changes the fetch method from urllib to curl because of the recurrent FetchErrors in spack while downloading the sources.

@aurianer aurianer added the category: CI Continuous Integration label Feb 8, 2024
@aurianer aurianer added this to the 0.23.0 milestone Feb 8, 2024
@aurianer aurianer self-assigned this Feb 8, 2024
@pika-bot
Copy link
Collaborator

pika-bot commented Feb 8, 2024

Performance test report

pika Performance

Comparison

BENCHMARKRESULT
Task Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Commit02f9de837b7661
pika Datetime2023-08-21T11:44:55+00:002024-02-08T15:13:18+00:00
Hostnamenid01181nid00025
Envfile
Clusternamedaintdaint
Datetime2023-08-21T13:50:51.685166+02:002024-02-08T16:21:50.493148+01:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@aurianer aurianer marked this pull request as draft February 8, 2024 20:52
@aurianer aurianer force-pushed the add_santis_runner_pipeline branch 4 times, most recently from 0778a53 to 9de624b Compare February 13, 2024 08:50
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKRESULT
Task Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Commit02f9de88b6198d
pika Datetime2023-08-21T11:44:55+00:002024-02-13T08:50:45+00:00
Hostnamenid01181nid00881
Datetime2023-08-21T13:50:51.685166+02:002024-02-13T09:54:21.064912+01:00
Envfile
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clusternamedaintdaint

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKRESULT
Task Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Datetime2023-08-21T11:44:55+00:002024-02-13T08:50:45+00:00
pika Commit02f9de88b6198d
Hostnamenid01181nid01183
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile
Datetime2023-08-21T13:50:51.685166+02:002024-02-13T09:58:45.932149+01:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@aurianer aurianer force-pushed the add_santis_runner_pipeline branch from 9de624b to 575beba Compare February 16, 2024 13:46
@aurianer aurianer mentioned this pull request Feb 16, 2024
16 tasks
@aurianer aurianer force-pushed the add_santis_runner_pipeline branch 15 times, most recently from 219aaff to 601b787 Compare February 19, 2024 14:55
@aurianer aurianer force-pushed the add_santis_runner_pipeline branch from 9d8046e to a45b427 Compare February 28, 2024 08:09
.gitlab/pipeline.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

I would be in favour of moving the make_multiarch_image as a part of the spack_base stage so that all the pipelines still fit in the screen without having to scroll right

Did you decide not to do the above in the end? If so, why?

cf this job

Could you update the above in the PR description? The last cf this job has no link.

@aurianer aurianer force-pushed the add_santis_runner_pipeline branch from a45b427 to 0273e8e Compare February 28, 2024 09:35
@aurianer
Copy link
Contributor Author

aurianer commented Feb 28, 2024

Did you decide not to do the above in the end? If so, why?

I did it, it was not pushed sorry

Could you update the above in the PR description? The last cf this job has no link.

I removed the cf since the links will anyway point to nothing after a while with the cleanup Andreas but in place. It would take me some unecessary time to look it up again. Will try to be more thorough next time not to forget the link

@msimberg
Copy link
Contributor

Did you decide not to do the above in the end? If so, why?

I did it, it was not pushed sorry

Could you update the above in the PR description? The last cf this job has no link.

I removed the cf since the links will anyway point to nothing after a while with the cleanup Andreas but in place. It would take me some unecessary time to look it up again. Will try to be more thorough next time not to forget the link

No worries, and thanks!

It looks like jfrog is unhappy. My approval stands so let's get this merged, but I'd like to see it get merged cleanly through CI, so let's see if jfrog starts behaving better soon and try again.

@msimberg msimberg added this pull request to the merge queue Feb 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2024
@aurianer aurianer added this pull request to the merge queue Feb 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 29, 2024
@aurianer aurianer force-pushed the add_santis_runner_pipeline branch from 24d2d4a to 65740f2 Compare March 1, 2024 12:47
@aurianer aurianer force-pushed the add_santis_runner_pipeline branch from 65740f2 to 436b7e0 Compare March 1, 2024 13:01
@msimberg msimberg added this pull request to the merge queue Mar 4, 2024
@msimberg msimberg removed this pull request from the merge queue due to a manual request Mar 4, 2024
@msimberg msimberg added this pull request to the merge queue Mar 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2024
@msimberg msimberg added this pull request to the merge queue Mar 4, 2024
@msimberg msimberg removed this pull request from the merge queue due to a manual request Mar 4, 2024
@msimberg msimberg removed this from the 0.23.0 milestone Mar 7, 2024
@msimberg msimberg added this pull request to the merge queue Mar 8, 2024
Merged via the queue into pika-org:main with commit 797f072 Mar 8, 2024
37 of 38 checks passed
@msimberg msimberg added this to the 0.24.0 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CI Continuous Integration
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

3 participants