Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of std::invoke_result in tag_invoke_result and variants #1058

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

msimberg
Copy link
Contributor

This replaces the use of std::invoke_result to compute tag_invoke_result* with a direct use of decltype. At least with libstdc++ std::invoke_result results in three levels of template instantiations. Since we in these cases know that we are only making direct function calls, never member function calls, we don't need the more expensive std::invoke_result. This very slightly improves compile times in DLA-Future.

@msimberg msimberg self-assigned this Mar 13, 2024
@msimberg msimberg added this pull request to the merge queue Mar 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2024
@msimberg msimberg added this to the 0.24.0 milestone Mar 14, 2024
@msimberg msimberg merged commit ffcd9e8 into pika-org:main Mar 18, 2024
37 of 38 checks passed
@msimberg msimberg deleted the tag-invoke-no-invoke-result branch March 18, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

1 participant