Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for drop_value sender adaptor #1287

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

msimberg
Copy link
Contributor

No description provided.

@msimberg msimberg added this to the 0.30.0 milestone Oct 23, 2024
@msimberg msimberg self-assigned this Oct 23, 2024
@msimberg msimberg force-pushed the drop-value-documentation branch from 48072c9 to 4e51479 Compare October 23, 2024 15:07
Copy link

codacy-production bot commented Oct 23, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.08% (target: -1.00%) 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (922a33c) 18260 13777 75.45%
Head commit (0248507) 18259 (-1) 13791 (+14) 75.53% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1287) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@msimberg msimberg force-pushed the drop-value-documentation branch from 4e51479 to 0248507 Compare October 23, 2024 15:09
Copy link
Contributor

@biddisco biddisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@msimberg msimberg merged commit 0e5a41a into pika-org:main Oct 30, 2024
37 checks passed
@msimberg msimberg deleted the drop-value-documentation branch October 30, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

4 participants