Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate compiler and deps installation #968

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Separate compiler and deps installation #968

merged 1 commit into from
Jan 17, 2024

Conversation

aurianer
Copy link
Contributor

@aurianer aurianer commented Jan 15, 2024 •
edited by msimberg
Loading

Fix #962.

@aurianer aurianer added the category: CI Continuous Integration label Jan 15, 2024
@aurianer aurianer added this to the 0.22.0 milestone Jan 15, 2024
@aurianer aurianer self-assigned this Jan 15, 2024
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer aurianer force-pushed the separate_compiler_and_deps_installation branch from a826fcc to 87fc384 Compare January 15, 2024 19:10
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer aurianer mentioned this pull request Jan 15, 2024
Merged
@aurianer aurianer force-pushed the separate_compiler_and_deps_installation branch from 87fc384 to 6343100 Compare January 15, 2024 19:25
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer aurianer force-pushed the separate_compiler_and_deps_installation branch 2 times, most recently from dd6755d to 2fe54e6 Compare January 16, 2024 07:54
@aurianer
Copy link
Contributor Author

cscs-ci run

@msimberg msimberg mentioned this pull request Jan 16, 2024
Merged
@aurianer aurianer force-pushed the separate_compiler_and_deps_installation branch 2 times, most recently from 2fe54e6 to d55e636 Compare January 17, 2024 09:46
@aurianer aurianer marked this pull request as ready for review January 17, 2024 09:46
@aurianer
Copy link
Contributor Author

cscs-ci run

msimberg
msimberg requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking mostly good, but some minor changes needed (only commented on one config, but the same comments apply to all).

.gitlab/includes/clang11_pipeline.yml Outdated Show resolved Hide resolved
.gitlab/includes/clang11_pipeline.yml Outdated Show resolved Hide resolved
.gitlab/includes/clang11_pipeline.yml Outdated Show resolved Hide resolved
.gitlab/includes/clang11_pipeline.yml Outdated Show resolved Hide resolved
@aurianer aurianer force-pushed the separate_compiler_and_deps_installation branch from d55e636 to 01a1bd2 Compare January 17, 2024 11:15
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer aurianer force-pushed the separate_compiler_and_deps_installation branch from 01a1bd2 to 6c32fa7 Compare January 17, 2024 11:44
@aurianer
Copy link
Contributor Author

cscs-ci run

1 similar comment
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer aurianer force-pushed the separate_compiler_and_deps_installation branch from 16746f4 to ed6e612 Compare January 17, 2024 15:03
msimberg
msimberg requested changes Jan 17, 2024
View reviewed changes
.gitlab/includes/clang11_pipeline.yml Outdated Show resolved Hide resolved
.gitlab/includes/clang11_pipeline.yml Outdated Show resolved Hide resolved
.gitlab/includes/clang12_pipeline.yml Outdated Show resolved Hide resolved
@aurianer aurianer force-pushed the separate_compiler_and_deps_installation branch 2 times, most recently from f64f683 to 091d126 Compare January 17, 2024 15:37
@aurianer
Copy link
Contributor Author

cscs-ci run

msimberg
msimberg approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the typo this looks good to go, feel free to merge once it passes CI.

@aurianer aurianer force-pushed the separate_compiler_and_deps_installation branch from 091d126 to a4f0711 Compare January 17, 2024 16:24
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer aurianer enabled auto-merge January 17, 2024 19:09
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer aurianer disabled auto-merge January 17, 2024 19:45
@aurianer
Copy link
Contributor Author

The failures are unrelated, merging manually

@aurianer aurianer merged commit 38670f0 into pika-org:main Jan 17, 2024
63 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@aurianer aurianer

Labels
category: CI Continuous Integration
Projects
pika planning board
Archived in project
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

Separate compiler and dependency images into separate stages in CSCS CI
2 participants
@aurianer @msimberg