Optimize JPEG scanline copy of yuv format #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In our current source, when encoding JPEG with CPU we'll first convert the yuv pixel int rgb, but from jpeg spec, encoder using YCbCr which is yuv internally (see also: JPEG#Encoding), this means we can passthrough the yuv value to encoder directly without converting to RGB.
Changes
V4L2_PIX_FMT_YUYV
andV4L2_PIX_FMT_UYVY
copy the yuv value directly into scanline buffer instead of convert to rgbTest
Run on my RK3399 board with asan enabled, no error found
Performance test
-O3 -march='armv8-a' -mtune='cortex-a72.cortex-a53
./ustreamer --device=/dev/video0 -r 1280x720 --quality=80 --encoder=CPU