Fix crash on FreeBSD due to incorrect thr_self system call invocation

[yurivict]

The correct signature is:
int thr_self(long *id);

It was called as thr_self() which caused memory corruption.

---

Alternatively, it can be called directly, without syscall, according to its manpage:

NAME
     thr_self – return thread identifier for the calling thread

LIBRARY
     Standard C Library (libc, -lc)

SYNOPSIS
     #include <sys/thr.h>

     int
     thr_self(long *id);

---

Other *BSDs likely have the same problem.

[yurivict]

Additionally, this patch also wouldn't hurt:

--- src/libs/logging.c.orig     2024-08-15 18:51:51 UTC
+++ src/libs/logging.c
@@ -31,4 +31,4 @@ bool us_g_log_colored;

 bool us_g_log_colored;

-pthread_mutex_t us_g_log_mutex;
+pthread_mutex_t us_g_log_mutex = PTHREAD_MUTEX_INITIALIZER;

I am not sure if PTHREAD_MUTEX_INITIALIZER is required, but PTHREAD_MUTEX_INITIALIZER is defined so it might make sense to use it.

[mdevaev]

Thanks. I have superficially checked other BSDs, it should be ok. In any case, I will be waiting for bug reports.

About the mutex - it's initialized inside US_LOGGING_INIT().

[mdevaev]

6.13 released with this fix.