Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring. From Singleton to Static Factory #3

Closed
wants to merge 13 commits into from

Conversation

libraua
Copy link
Contributor

@libraua libraua commented Jul 3, 2015

No description provided.

@pilgr
Copy link
Owner

pilgr commented Jul 4, 2015

I guess you should sync your fork repo with main Paper repo and rebase your commits (a04092d, 395adba) before making a pull request. Just to to avoid many merge commits.

Paper.put("city", "Lund"); // Primitive
Paper.put("task-queue", queue); // LinkedList
Paper.put("countries", countryCodeMap); // HashMap
Paper.book().write("city", "Lund"); // Primitive
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes to README shouldn't be visible till publish version 1.0. I'll create development branch. Then please move all your changes into development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants