Decrease minimum sdk requirements to API 8 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, min sdk should be changed. But simple app still should be there as we have plan to fill in it with examples and demo. Please remove second commit from your pull request. |
|
Have you tried to run all tests on device with api 8? |
|
I guess it can be readded then once set up, it will just confuse people, but i will do as you said :) I ran my app inside an emulator and it worked, but i will do further tests, like running the unit tests. Shipped my app also to beta testers on Google Play and it looks good so far. Will report back once i have ran the unit tests, together with results. |
* There is no need to set the minimum sdk version to 15.
Allow to use it on older apis as well
* Hawk depends on API 8, so set the minimum sdk to 8 as well.
Paper will build with an even lower sdk as well, just the tests
will fail to build and API 8 is a reasonable number as it covers
99% of the target audience.
Change-Id: I0365859041743ce078af4f02c29c86c55a64b403
Signed-off-by: Alexander Martinz <eviscerationls@gmail.com>
pilgr
added a commit
that referenced
this pull request
Jul 6, 2015
Decrease minimum sdk requirements to API 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the useless app which did not contain any samples and decreases the minimum sdk from 15 to 8.
I have choosen 8 because the test dependency of Hawk depends on API 8 and with API 8 we are targeting 99% of the android audience anyways, so it seems to be a reasonable number to me.