-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript .d.ts
file for type checking
#72
Conversation
86590d9
to
caafd9c
Compare
This is super awesome! What I wound wonder, especially if we start adding this to other modules, is I under if there is a way to use TypeScript to valid the bindings file against the JavaScript file? Is that even possible through some kind of command line? |
@dougwilson I spent some time thinking about it from last year, and yes, there is. I was considering making a more complex toolchain, but an easy way is to just use the (TypeScript) compiler. We can either compile a Edit: Using |
I'm not certain which one makes the most sense :) What I'm thinking is that either there could be a |
Hmm, ok. I was thinking you'd just have part of the test suite as literally a TypeScript file and that would enable the type checking on what you're doing. Are you think more along that there should be a way to load the JavaScript file and the definition file and "overlay" them to check if they're valid? I don't think TypeScript has anything like that, at least not right now, but the advantage of writing it against the actual test suite would be that we continuously test the defined options parameters, etc. to ensure accuracy. |
caafd9c
to
de6cebc
Compare
Tweaked the test suite into TypeScript for continuous integration and type checking of the public interface
de6cebc
to
78f0a5d
Compare
@dougwilson I committed a version using |
Tweaked the test suite into TypeScript for continuous integration and type checking of the public interface
No description provided.