Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SessionsController #89

Open
nidalaa opened this issue Mar 3, 2016 · 0 comments
Open

Change SessionsController #89

nidalaa opened this issue Mar 3, 2016 · 0 comments
Assignees
@mejcz
Labels
Done
Milestone
Lesson 9 — Tools

Comments

@nidalaa
Copy link

nidalaa commented Mar 3, 2016

Sessions controller should handle both Facebook and email login. When request.env["omniath.auth"] exists and contains uid, use FacebookAccount. Otherwise, use Account class.

Please store account_type with account_id in the session. Fix methods in ApplicationController to support Facebook accounts.
@nidalaa nidalaa added this to the Lesson 9 — Tools milestone Mar 3, 2016
@nidalaa nidalaa added the Free label Mar 3, 2016
matisnape pushed a commit that referenced this issue Mar 20, 2016
update routes [#89]
fd5845e
matisnape pushed a commit that referenced this issue Mar 20, 2016
update application controller to use FacebookAccount as well [#89]
9310acb
matisnape pushed a commit that referenced this issue Mar 20, 2016
add omniauth to sessions [#89]
aee771e
matisnape pushed a commit that referenced this issue Mar 20, 2016
update scope for fb [#89]
731bef9
matisnape pushed a commit that referenced this issue Mar 20, 2016
info_fields, not scope [#89]
8d3386f
matisnape pushed a commit that referenced this issue Mar 22, 2016
refactor create session [#89]
eaf64ee
matisnape pushed a commit that referenced this issue Mar 22, 2016
update current_person method to accept different kinds of accounts [#89]
abf6f81
matisnape pushed a commit that referenced this issue Mar 22, 2016
refactor methods [#89]
3563cb5
matisnape pushed a commit that referenced this issue Mar 22, 2016
fix - return nil is needed [#89]
180eab7
matisnape pushed a commit that referenced this issue Mar 22, 2016
change ruby version [#89]
acdf939
matisnape pushed a commit that referenced this issue Mar 22, 2016
checking sth [#89]
ce05d69
matisnape pushed a commit that referenced this issue Mar 22, 2016
don't need it anymore [#89]
040781a
@matisnape matisnape added Done and removed Free labels Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mejcz mejcz

Labels
Done
Projects
None yet
Milestone
Lesson 9 — Tools
Development

No branches or pull requests
3 participants
@matisnape @nidalaa @mejcz