Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

himalaya --version doesn't specify what beta build it is #496

Closed
echo-bravo-yahoo opened this issue Nov 7, 2024 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@echo-bravo-yahoo
Copy link

~ ❯ himalaya --version
himalaya 1.0.0

while himalaya's in an extended 1.0.0 beta, it should probably report the beta release or commit hash.

soywod added a commit that referenced this issue Nov 11, 2024
@soywod soywod self-assigned this Nov 11, 2024
@soywod soywod added the enhancement New feature or request label Nov 11, 2024
@soywod soywod added this to Pimalaya Nov 11, 2024
@soywod soywod moved this to In Progress in Pimalaya Nov 11, 2024
@soywod
Copy link
Member

soywod commented Nov 11, 2024

--version is automatically generated by clap. I dived a bit into the subject, and I found that clap can generate a short version (-V) and a long version (--version). I was able to customize the long one thanks to a custom build.rs, and it looks like this:

$ himalaya -V
himalaya v1.0.0

$ himalaya --version
himalaya 1.0.0 linux gnu x86_64 git branch master rev d4b81a82944ca595071d459fd3f3fc8209dc3ac1

@soywod soywod closed this as completed Nov 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Pimalaya Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants