Constructors question

[jason-engage]

Hey Fabian, what's your opinion on making constuctors?

At the moment, we have a series of parameters - and they are getting out of order.

Should a constructor just accept an array instead? Should that be how 2.0 works?

[wittfabian]

Very good question.

[wittfabian]

Should we tag the current status as a new version?

[Yiidiir]

@wittfabian I believe that we should rewrite the code, tbh an important thing to do is parsing the request array within the class and fetch the data accordingly. It's super messy and weird to use arrays with index 0 to access data etc..

[arsengoian]

Are you going to maintain compatibility in class constructors?

[jason-engage]

I wouldn't think so. Time consuming and complicated. Parameters would be the same but required within a key value array instead.

On Sun, Mar 4, 2018 at 3:25 AM Arsen Goian ***@***.***> wrote: Are you going to maintain compatibility in class constructors? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#132 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEP0mLey-sG7Tp29ylJ3EMLdkVyb5Xryks5tavwygaJpZM4SRQ-D> .

-- * Jason Shaw <jason@engageify.com>*, Developer Tel. 647 783 7463 | Skype: jason.engage en.gg | <http://en.gg/>Follow me on Facebook <http://www.facebook.com/engagetheweb>