Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix - show filtered inherited cs values on grid #604

Open
wants to merge 2 commits into
base: 1.6
Choose a base branch
from

Conversation

pfilipkowskilemon
Copy link
Contributor

@pfilipkowskilemon pfilipkowskilemon commented Jul 4, 2024

Copy link

github-actions bot commented Jul 4, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pfilipkowskilemon
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@robertSt7
Copy link
Contributor

robertSt7 commented Jul 5, 2024

Hi @pfilipkowskilemon Since this is a bugfix, could you please change the base branch to 1.5? Thanks

@pfilipkowskilemon pfilipkowskilemon changed the base branch from 1.x to 1.5 July 5, 2024 10:32
@robertSt7 robertSt7 self-assigned this Jul 12, 2024
@robertSt7
Copy link
Contributor

Hi @pfilipkowskilemon thanks for changing the branch.
This approach only works across two levels but not across three levels of inheritance. Could you please also take a look at this? Thx
image

@pfilipkowskilemon
Copy link
Contributor Author

Hi @robertSt7 I apologize for the late reply. You are correct about the fact that it only works for two levels. This solution fits for my client so I thought it might be useful for others.
Unfortunately, I have no idea how to improve this mechanism. So if you want to close PR then there is no problem.

@robertSt7
Copy link
Contributor

@pfilipkowskilemon no worries. Sorry we don't have time at the moment to have a deeper look at this. We will come back to this later. Maybe you find a solution or some of the other community member has an idea in the meanwhile, we would highly welcome this.

@kingjia90 kingjia90 changed the base branch from 1.5 to 1.6 October 1, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants