-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run some workflows only in pimcore repos #606
base: 1.6
Are you sure you want to change the base?
Conversation
@herbertroth Do this work with PRs from forks? |
@blankse This disables CS Fixer runs on PRs from forks. It’s simply not possible to do this on PRs for forks. This would require a way to get write permissions on the forked repo with a token stored at Pimcore. For very good reasons, this can’t work. So the CS Fixer will only run for PRs for a Pimcore-owned repo to avoid error messages indicating that a token is not present. |
@herbertroth But with the For example see here: pimcore/pimcore#17012 |
@blankse This PR solves a different problem. If you fork this to E.G.: blankse/pimcore and than do a PR to blankse/pimcore this will run and try to find a key stored at pimcore. The key will not be present and will trigger an error. If you do a PR from blankse/pimcore to pimcore/pimcore this will work. |
@herbertroth Yes, with |
@blankse I would be happy if we could test this together after the merge. It’s tricky to do this alone. |
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
No description provided.