Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: display the nice path if field type combo is not editable #731

Open
wants to merge 1 commit into
base: 1.6
Choose a base branch
from

Conversation

patrickbitzer
Copy link

@patrickbitzer patrickbitzer commented Oct 23, 2024

I had the phenomenon that when I had set a OneToManyRelation field with the Inline Search type, the PathFormatter was not applied there. The problem occurres only when the user is in not editable mode.

image

I have made an adjustment that fixes the problem.

image-20241022-123834

Copy link

github-actions bot commented Oct 23, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@patrickbitzer patrickbitzer changed the title HOTFIX: display the nice path if field type combo is not editable BUG: display the nice path if field type combo is not editable Oct 23, 2024
@patrickbitzer
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@patrickbitzer
Copy link
Author

I updated the description

@blankse
Copy link
Contributor

blankse commented Oct 23, 2024

@patrickbitzer Target branch for bug fixes should be 1.6. Can you rebase it?

@patrickbitzer patrickbitzer changed the base branch from 1.x to 1.6 October 24, 2024 10:38
@patrickbitzer patrickbitzer force-pushed the hotfix/display-nicepath-in-combo-field-of-many-to-one-relation-field branch from 8bf1af8 to c9a441c Compare October 24, 2024 10:42
@patrickbitzer
Copy link
Author

@blankse maybe done.

@blankse
Copy link
Contributor

blankse commented Oct 24, 2024

@patrickbitzer You still have commits from 1.x in your branch. You need to rebase with the --onto option to remove them:
git rebase --onto origin/1.6 origin/1.x
Then, you need to push with the --force option:
git push --force

@patrickbitzer patrickbitzer force-pushed the hotfix/display-nicepath-in-combo-field-of-many-to-one-relation-field branch from c9a441c to a393318 Compare October 24, 2024 11:10
@patrickbitzer
Copy link
Author

@blankse sorry. I have done now

Copy link

sonarcloud bot commented Oct 24, 2024

@mattamon mattamon self-assigned this Nov 8, 2024
@mattamon
Copy link
Contributor

mattamon commented Nov 8, 2024

@patrickbitzer Could you explain this a little more? What do you mean by inline search type?
I cannot reproduce this with my local instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants