Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pimcore 11 Support #10

Merged
merged 9 commits into from
May 2, 2023
Merged

Pimcore 11 Support #10

merged 9 commits into from
May 2, 2023

Conversation

fashxp
Copy link
Member

@fashxp fashxp commented Apr 21, 2023

@fashxp fashxp added this to the v2.0.0 milestone Apr 21, 2023
@martineiber
Copy link
Contributor

I have created a 2.x branch, and we should merge it into this branch, right?

@dvesh3
Copy link
Contributor

dvesh3 commented May 2, 2023

@martineiber we can merge this to 1.x and rename 1.x to 2.x since we don't have any pending minor changes to tag on the branch.

Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to PimcoreBundleAdminClassicInterface.

src/Resources/skeleton/bundle/Bundle.php.twig Outdated Show resolved Hide resolved
src/Resources/skeleton/bundle/Bundle.php.twig Outdated Show resolved Hide resolved
src/Resources/skeleton/bundle/Bundle.php.twig Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com>
@fashxp
Copy link
Member Author

fashxp commented May 2, 2023

@dvesh3 @martineiber please apply all the changes and retest then the generated bundles, thx.

Copy link
Contributor

@martineiber martineiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvesh3 dvesh3 merged commit 605bbd8 into 1.x May 2, 2023
@dvesh3 dvesh3 deleted the pimcore_11 branch May 2, 2023 14:39
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants