-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded to PHP CS Fixer v3 #532
Conversation
PhpStan is fixed by #533 |
d963961
to
67a1121
Compare
Merged the 4.0 branch to fix the php stan errors here |
@blankse With this the CS fixer changes would be handled in the PR and for example in this one we could directly see the changes. When merging a PR we could then squash it and would have a clean commit history. WDYT? |
@markus-moser I would also prefer this. Did you test it with pull requests from forks? It seems not to work. The |
Might work now. The changes are from: https://github.com/stefanzweifel/git-auto-commit-action?tab=readme-ov-file#workflow-should-run-in-base-repository See also: stefanzweifel/git-auto-commit-action#211 |
@blankse Oh, sorry, no I never tested it with forks. Thank you very much for figuring this tricky thing out, let's give it a try 👍 |
See other pimcore repositories