Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop twig deferred blocks and deprecated pimcore_* twig extension calls #540

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

markus-moser
Copy link
Contributor

@markus-moser markus-moser commented Aug 7, 2024

Related to pimcore/pimcore#17444

  • Deferred blocks are not needed, everthing works without the deferred attribute too. As this extension does not work with twig >=3.9.0 it's removed now.

    • The only exception could be if someone extends the CMF layout in custom code and calls the pimcore_head_link extension within the content block. In that case the call would need to be moved outside of the content block. But that's a real edge case!
  • The deprecated usage of pimcore_head_script().captureStart() is replaced with an alternative approach.

@markus-moser markus-moser added this to the 4.2.0 milestone Aug 7, 2024
@markus-moser markus-moser modified the milestones: 4.2.0, 5.0.0 Aug 29, 2024
@markus-moser markus-moser marked this pull request as draft August 29, 2024 10:09
@markus-moser markus-moser modified the milestones: 5.0.0, 4.1.2 Sep 23, 2024
@markus-moser
Copy link
Contributor Author

As without a updated twig version we have security problems (see pimcore/pimcore#17457 (comment)) we need to remove the deferred blocks extension right now as bugfix as it is incompatible with current versions.

@markus-moser markus-moser added Bug and removed BC-BREAK labels Sep 23, 2024
@markus-moser markus-moser changed the base branch from 4.x to 4.1 September 23, 2024 14:05
@markus-moser markus-moser marked this pull request as ready for review September 23, 2024 14:32
@markus-moser markus-moser merged commit d6e2b9c into 4.1 Sep 23, 2024
9 checks passed
@markus-moser markus-moser deleted the drop-deferred-blocks branch September 23, 2024 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants