Update definitions #533
Merged
Update definitions #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We must wait for pimcore/ecommerce-framework-bundle#119 and pimcore/customer-data-framework#494 |
blankse
force-pushed
the
fix_index_attributes
branch
from
34bc6b8 to
799de09
Compare
blankse
force-pushed
the
fix_index_attributes
branch
from
799de09 to
3e74147
Compare
|
@dvesh3 @kingjia90 Is ready to review now. |
kingjia90
reviewed
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saved all classes/fieldcollections/objectbricks to update wrong data types (for example index should be boolean) und remove legacy attributes (for example previewUrl, generateTypeDeclarations)