Make log level persisting optional #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to set a higher log level in production by default but don't want it to be saved on users' browsers. Making persistence optional seemed like a good way to achieve this. The patch keeps the old behavior (persist by default) for backwards compatibility.
|
Thanks! In principle I'm fine with this, but could you please document it in the readme, and add a couple of tests covering it? Let me know if you need any help. |
|
bump :) |
pimterry
added a commit
that referenced
this pull request
Jun 1, 2015
Make log level persisting optional
|
Ah, sorry, github doesn't ping when you add commits to a PR, only when you comment. Merged now, thanks for this! |
No worries. I had the same issue so I should have pinged you earlier :) Should I expect a new release on bower soon? ;) |
|
New release (1.3.0) pushed, should be able to see it on Bower/NPM/etc immediately. |
|
Thank you! Btw. sorry that I forgot the rebase, that ugliness, ugh :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to set a higher log level in production by default but don't want it to be saved on users' browsers. Making persistence optional seemed like a good way to achieve this. The patch keeps the old behavior (persist by default) for backwards compatibility.