Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoke default file manager when notes o is invoked. #60

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rmNULL
Copy link
Contributor

@rmNULL rmNULL commented Apr 9, 2018

Fixes

Fixes #58 #57
Closes #58 #57

Checklist

  • I have made a change to this repository, be it functionality, testing, documentation, spelling, or grammar.
  • I updated my branch with the master branch.
  • I have added the necessary testing to prove my fix is effective/my feature works (or I did not modify functionality).
  • I have added necessary documentation about the functionality in an appropriate .md file.
  • I have appropriately commented any code I have modified

Short description of what this PR does:

  • for Feedback ...

@primis
Copy link
Collaborator

primis commented Apr 16, 2018

Have you added tests to address the fix?

@rmNULL
Copy link
Contributor Author

rmNULL commented Apr 17, 2018

@primis nope, I have problem running bats on my system.

@eshapard
Copy link
Contributor

I noticed this option and that the open command is problematic last night.

I think it might be easier to set a config file variable with a default value that the user can override.

Maybe: FILE_MAN=open
and then open the directory with: $FILE_MAN $notes_directory

Add some documentation and let the user decide what kind of command-line or gui file manager he wants to use for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants