-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vdir: use custom implementation of atomic_write
#1393
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d80da54
to
efd186f
Compare
WhyNotHugo
reviewed
Feb 12, 2025
dc3541c
to
2ebadd4
Compare
WhyNotHugo
reviewed
Feb 13, 2025
8817e10
to
48dabad
Compare
48dabad
to
9cf674d
Compare
WhyNotHugo
reviewed
Feb 13, 2025
9cf674d
to
786ffbf
Compare
WhyNotHugo
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Haven't had a change to properly test it yet.
Alas, it is one of those pieces of code where all of the "interesting" behavior is along the error path :/ . |
The `atomicwrites` library has been abandoned. This implementation is a bit stripped down a bit from what the library provided. Fixes: pimutils#1387
786ffbf
to
62031dc
Compare
Applied via 62031dc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
atomicwrites
library has been abandoned.This implementation is a bit stripped down a bit from what the library provided.
Fixes: #1387