Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdir: use custom implementation of atomic_write #1393

Closed
wants to merge 1 commit into from

Conversation

mathstuf
Copy link
Contributor

The atomicwrites library has been abandoned.

This implementation is a bit stripped down a bit from what the library provided.

Fixes: #1387

@mathstuf mathstuf force-pushed the remove-atomicwrites-usage branch 5 times, most recently from d80da54 to efd186f Compare February 12, 2025 22:57
@mathstuf mathstuf force-pushed the remove-atomicwrites-usage branch 2 times, most recently from dc3541c to 2ebadd4 Compare February 13, 2025 00:08
@mathstuf mathstuf force-pushed the remove-atomicwrites-usage branch 2 times, most recently from 8817e10 to 48dabad Compare February 13, 2025 00:54
@mathstuf mathstuf marked this pull request as ready for review February 13, 2025 00:55
@mathstuf mathstuf force-pushed the remove-atomicwrites-usage branch from 48dabad to 9cf674d Compare February 13, 2025 13:05
@mathstuf mathstuf force-pushed the remove-atomicwrites-usage branch from 9cf674d to 786ffbf Compare February 14, 2025 08:36
Copy link
Member

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Haven't had a change to properly test it yet.

@mathstuf
Copy link
Contributor Author

Alas, it is one of those pieces of code where all of the "interesting" behavior is along the error path :/ .

The `atomicwrites` library has been abandoned.

This implementation is a bit stripped down a bit from what the library
provided.

Fixes: pimutils#1387
@WhyNotHugo WhyNotHugo force-pushed the remove-atomicwrites-usage branch from 786ffbf to 62031dc Compare February 21, 2025 13:49
@WhyNotHugo
Copy link
Member

Applied via 62031dc

@WhyNotHugo WhyNotHugo closed this Feb 21, 2025
@mathstuf mathstuf deleted the remove-atomicwrites-usage branch February 21, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Away From Unmaintained atomicwrites Library
2 participants