Add click-log #106
Merged
Add click-log #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhyNotHugo
requested changes
Feb 18, 2017
Member
WhyNotHugo
left a comment
WhyNotHugo
left a comment
There was a problem hiding this comment.
Oh, cool, we don't need to replace all the logger calls. Didn't know that, nice!
todoman/cli.py
Outdated
| TODO_ID_MIN = 1 | ||
| with_id_arg = click.argument('id', type=click.IntRange(min=TODO_ID_MIN)) | ||
|
|
||
| logger = logging.getLogger(__name__) |
todoman/cli.py
Outdated
|
|
||
|
|
||
| @click.group(invoke_without_command=True) | ||
| @click_log.init('vdirsyncer') |
Member
Author
|
Fixed both of your comments. |
WhyNotHugo
approved these changes
Feb 18, 2017
WhyNotHugo
requested changes
Feb 20, 2017
Member
WhyNotHugo
left a comment
WhyNotHugo
left a comment
There was a problem hiding this comment.
Feel free to merge after reviewing the changelog.
| v2.1.0 | ||
| ------ | ||
|
|
||
| * New PyPI dependency ``click-log``. |
Member
There was a problem hiding this comment.
Please also mention the new --verbosity flag.
WhyNotHugo
reviewed
Feb 20, 2017
| v2.1.0 | ||
| ------ | ||
|
|
||
| * The global ``--verbosity`` option has been introduced. It doesn't do much for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13