Merge pull request #67 from ori-edge/fix-apex

fixed SOA query not returning an answer
pinax-network · Jan 10, 2022 · a4cbd09 · a4cbd09
2 parents 0ac6af2 + d61176d
commit a4cbd09
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/apex_dual_test.go b/apex_dual_test.go
@@ -61,7 +61,7 @@ var testsDualNS = []test.Case{
 	{
 		Qname: "example.com.", Qtype: dns.TypeSOA,
 		Rcode: dns.RcodeSuccess,
-		Ns: []dns.RR{
+		Answer: []dns.RR{
 			test.SOA("example.com.	60	IN	SOA	dns1.kube-system.example.com. hostmaster.example.com. 1499347823 7200 1800 86400 5"),
 		},
 	},

diff --git a/apex_test.go b/apex_test.go
@@ -49,7 +49,7 @@ var testsApex = []test.Case{
 	{
 		Qname: "example.com.", Qtype: dns.TypeSOA,
 		Rcode: dns.RcodeSuccess,
-		Ns: []dns.RR{
+		Answer: []dns.RR{
 			test.SOA("example.com.	60	IN	SOA	dns1.kube-system.example.com. hostmaster.example.com. 1499347823 7200 1800 86400 5"),
 		},
 	},

diff --git a/gateway.go b/gateway.go
@@ -175,7 +175,7 @@ func (gw *Gateway) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Ms
 		// Force to true to fix broken behaviour of legacy glibc `getaddrinfo`.
 		// See https://github.com/coredns/coredns/pull/3573
 		m.Authoritative = true
-		m.Ns = []dns.RR{gw.soa(state)}
+		m.Answer = []dns.RR{gw.soa(state)}
 
 	case dns.TypeNS:
 

diff --git a/gateway_test.go b/gateway_test.go
@@ -143,7 +143,7 @@ var tests = []test.Case{
 	// SOA for the existing domain | Test 5
 	{
 		Qname: "domain.example.com.", Qtype: dns.TypeSOA, Rcode: dns.RcodeSuccess,
-		Ns: []dns.RR{
+		Answer: []dns.RR{
 			test.SOA("example.com.	60	IN	SOA	dns1.kube-system.example.com. hostmaster.example.com. 1499347823 7200 1800 86400 5"),
 		},
 	},