Feature/subtivity #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisCarriere
commented
Nov 22, 2023
src/clickhouse/stores.ts
Outdated
|
|
||
| private fetchData() { | ||
| this.ChainsPromise = client | ||
| .query({ query: "SELECT DISTINCT chain FROM blocks", format: "JSONEachRow" }) |
There was a problem hiding this comment.
I think we could replace blocks => module_hashes and it will be much faster since there's only a few rows
DenisCarriere
commented
Nov 22, 2023
src/config.ts
Outdated
| @@ -15,6 +15,7 @@ export const DEFAULT_MAX_LIMIT = 500; | |||
| export const DEFAULT_VERBOSE = false; | |||
| export const APP_NAME = pkg.name; | |||
| export const DEFAULT_SORT_BY = "DESC"; | |||
| export const DEFAULT_AGGREGATE_FUNCTION = "count"; | |||
There was a problem hiding this comment.
this should be sum
https://clickhouse.com/docs/en/sql-reference/aggregate-functions/reference/sum
count only counts the number of rows
https://clickhouse.com/docs/en/sql-reference/aggregate-functions/reference/count
DenisCarriere
commented
Nov 22, 2023
src/utils.ts
Outdated
| @@ -68,3 +78,70 @@ export function parseTimestamp(timestamp?: string|null|number) { | |||
| } | |||
| return undefined; | |||
| } | |||
|
|
|||
| export function parseAggregateFunction(aggregate_function?: string|null) { | |||
| if (aggregate_function == undefined || aggregate_function == null || aggregate_function == '') return "sum"; | |||
There was a problem hiding this comment.
This can be simplified to:
if (!aggregate_function) return "sum";
DenisCarriere
commented
Nov 22, 2023
src/utils.ts
Outdated
| } | ||
|
|
||
| export function parseHistoryRange(range?: string|null) { | ||
| if (range == undefined || range == '') return "24h"; |
There was a problem hiding this comment.
same simplified:
if (!range) return "24h";
github-actions
bot
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.