Skip to content

Commit

Permalink
Drop flake8, use pre-commit for workflows
Browse files Browse the repository at this point in the history
  • Loading branch information
spookylukey committed Sep 22, 2023
1 parent e7b040a commit 779800d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 28 deletions.
25 changes: 6 additions & 19 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,27 +54,14 @@ jobs:
run: |
./runtests.py
flake8:
pre-commit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Set up Python
uses: actions/setup-python@v2
- uses: actions/checkout@v3
- uses: actions/setup-python@v3
with:
python-version: '3.9'
- uses: actions/cache@v2
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-${{ '3.9' }}-${{ hashFiles('requirements*.txt') }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -e .
pip install -r requirements-dev.txt
- name: Lint with flake8
run: |
flake8 --version
flake8 .
python-version: "3.10"
- uses: pre-commit/action@v3.0.0

check-manifest:
runs-on: ubuntu-latest
Expand All @@ -92,7 +79,7 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install -e .
pip install -r requirements-dev.txt
pip install checkmanifest
- name: check-manifest
run: |
check-manifest
3 changes: 2 additions & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
flake8==3.8.4
check-manifest
ruff
black
4 changes: 0 additions & 4 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,3 @@ where = src
[options.package_data]
mailer =
locale/*/LC_MESSAGES/*.*

[flake8]
max-line-length = 100
exclude = src/mailer/migrations,build,.tox
5 changes: 1 addition & 4 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,12 @@ basepython =

commands =
test: coverage run ./runtests.py
flake: flake8 --statistics --benchmark
checkmanifest: check-manifest
allowlist_externals = flake8
deps =
coverage
-r requirements-test.txt
-e .
flake8: -r requirements-dev.txt
checkmanifest: -r requirements-dev.txt
checkmanifest: checkmanifest
django22: Django==2.2.19
django30: Django==3.0.14
django31: Django==3.1.12
Expand Down

0 comments on commit 779800d

Please sign in to comment.