Update stripe api version (to fix some issues) #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm initiating this api version bump because I'm encountering an issue
where when getting a failed invoice, pinax stripe is trying to get the
subscription, and if the subscription is already cancelled, it wouldn't
show. This has been changed (fixed?) in stripe API 2016-07-06.
I've taken the opportunity to upgrade to a slightly newer api version
since I've reviewed the changes and non of them look like they would
negatively affect pinax.stripe.
Way to reproduce my invoice issue:
Have a cancelled subscription followed by a cancelled invoice (happens
often here). Following that you'd get the following backtrace:
File "pinax/stripe/webhooks.py" in process
118. self.process_webhook()
File "pinax/stripe/webhooks.py" in process_webhook
414. send_receipt=settings.PINAX_STRIPE_SEND_EMAIL_RECEIPTS
File "pinax/stripe/actions/invoices.py" in sync_invoice_from_stripe_data
91. stripe_subscription = subscriptions.retrieve(c, sub_id)
File "pinax/stripe/actions/subscriptions.py" in retrieve
128. subscription = stripe.Subscription.retrieve(sub_id, stripe_account=customer.stripe_account_stripe_id)
File "stripe/api_resources/abstract/api_resource.py" in retrieve
13. instance.refresh()
File "stripe/api_resources/abstract/api_resource.py" in refresh
17. self.refresh_from(self.request('get', self.instance_url()))
File "stripe/stripe_object.py" in request
190. response, api_key = requestor.request(method, url, params, headers)
File "stripe/api_requestor.py" in request
152. resp = self.interpret_response(rbody, rcode, rheaders)
File "stripe/api_requestor.py" in interpret_response
359. self.handle_error_response(rbody, rcode, resp, rheaders)
File "stripe/api_requestor.py" in handle_error_response
177. raise err
Exception Type: InvalidRequestError at /stripe/webhook/
Exception Value: Request req_XXXXXXXX No such subscription:
sub_XXXXXXXXXX
req and sub were redacted by me.
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
==========================================
- Coverage 99.39% 99.38% -0.02%
==========================================
Files 34 34
Lines 1829 1793 -36
Branches 166 160 -6
==========================================
- Hits 1818 1782 -36
Misses 5 5
Partials 6 6
Continue to review full report at Codecov.
|
|
Side note: for Stripe we require an even later version already: https://github.com/pinax/pinax-stripe/blob/3d8c5b7adcaebc0846857e6605f1d1bcda4cf7b5/docs/user-guide/connect.md#using-stripe-connect |
|
Can you provide a link to the API doc changes, please? |
|
That's a good point. Link to the changelog: https://stripe.com/docs/upgrades#api-changelog |
blueyed
approved these changes
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm initiating this api version bump because I'm encountering an issue
where when getting a failed invoice, pinax stripe is trying to get the
subscription, and if the subscription is already cancelled, it wouldn't
show. This has been changed (fixed?) in stripe API 2016-07-06.
I've taken the opportunity to upgrade to a slightly newer api version
since I've reviewed the changes and non of them look like they would
negatively affect pinax.stripe.
Way to reproduce my invoice issue:
Have a cancelled subscription followed by a cancelled invoice (happens
often here). Following that you'd get the following backtrace:
File "pinax/stripe/webhooks.py" in process
118. self.process_webhook()
File "pinax/stripe/webhooks.py" in process_webhook
414. send_receipt=settings.PINAX_STRIPE_SEND_EMAIL_RECEIPTS
File "pinax/stripe/actions/invoices.py" in sync_invoice_from_stripe_data
91. stripe_subscription = subscriptions.retrieve(c, sub_id)
File "pinax/stripe/actions/subscriptions.py" in retrieve
128. subscription = stripe.Subscription.retrieve(sub_id, stripe_account=customer.stripe_account_stripe_id)
File "stripe/api_resources/abstract/api_resource.py" in retrieve
13. instance.refresh()
File "stripe/api_resources/abstract/api_resource.py" in refresh
17. self.refresh_from(self.request('get', self.instance_url()))
File "stripe/stripe_object.py" in request
190. response, api_key = requestor.request(method, url, params, headers)
File "stripe/api_requestor.py" in request
152. resp = self.interpret_response(rbody, rcode, rheaders)
File "stripe/api_requestor.py" in interpret_response
359. self.handle_error_response(rbody, rcode, resp, rheaders)
File "stripe/api_requestor.py" in handle_error_response
177. raise err
Exception Type: InvalidRequestError at /stripe/webhook/
Exception Value: Request req_XXXXXXXX No such subscription:
sub_XXXXXXXXXX
req and sub were redacted by me.
What's this PR do?
Any background context you want to provide?
What ticket or issue # does this fix?
Opened this instead of opening a ticket for the above issue.
Definition of Done (check if considered and/or addressed):
There should be none, as I only upgraded to an API version that didn't change anything that would affect pinax stripe.
None.
No relevant ones as I can see.
The normal test suite should cover it.