Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: use postgres user #592

Merged
merged 1 commit into from
Oct 10, 2018
Merged

CircleCI: use postgres user #592

merged 1 commit into from
Oct 10, 2018

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Sep 13, 2018

"root" is not available anymore?!

Ref: https://circleci.com/gh/lock8/pinax-stripe/1256

@blueyed
Copy link
Contributor Author

blueyed commented Sep 13, 2018

Hmm, seems to have been some temporary problem?!
At least #591 still failed with this commit.
Closing for now.

@blueyed blueyed closed this Sep 13, 2018
@blueyed blueyed deleted the fix-psql-tests branch September 13, 2018 06:32
@blueyed blueyed restored the fix-psql-tests branch September 13, 2018 06:37
@blueyed blueyed reopened this Sep 13, 2018
@blueyed
Copy link
Contributor Author

blueyed commented Sep 13, 2018

@jpic
Copy link

jpic commented Sep 13, 2018

We had to hardcode the user too in another project too with a similar setup (python + pg + cci)

@jpic
Copy link

jpic commented Sep 14, 2018

Note that we also needed to extend wait timeout from 10 secs (as specified by their docs) to 20:

betagouv/mrs@0fba65b
betagouv/mrs@09e5480

Then it started working again

@blueyed
Copy link
Contributor Author

blueyed commented Sep 15, 2018

@jpic
Thanks.
Do you know why this is necessary now? Have the circleci/postgres Docker images changed?

@paltman paltman added this to the Next milestone Oct 9, 2018
@blueyed
Copy link
Contributor Author

blueyed commented Oct 9, 2018

Included in #618.

@blueyed blueyed mentioned this pull request Oct 9, 2018
3 tasks
@blueyed
Copy link
Contributor Author

blueyed commented Oct 9, 2018

@paltman
It might make sense to change the codecov/patch status to not being required - it disallows me to merge this at least.
IIRC I've closed/re-opened to get it reported, but without luck apparently.
@codecov is having some issues in this regard since a while.

@paltman
Copy link
Contributor

paltman commented Oct 9, 2018 via email

@blueyed
Copy link
Contributor Author

blueyed commented Oct 9, 2018

@paltman
Thanks, next would be the "This branch is out-of-date with the base branch" check (like seen above).
Often it is not really necessary to ensure this, and in the unlikely case it would break master it is usually easy to fix.
E.g. in this case it does not really make sense to run CI again, just because a doc typo fix was merged.

@paltman
Copy link
Contributor

paltman commented Oct 10, 2018

@blueyed agreed and done.

@blueyed blueyed merged commit 9cbe58a into pinax:master Oct 10, 2018
@blueyed blueyed deleted the fix-psql-tests branch October 10, 2018 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants