Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make floor_generator null safe internally #434

Merged
merged 10 commits into from
Nov 21, 2020

Conversation

vitusortner
Copy link
Collaborator

@vitusortner vitusortner commented Nov 20, 2020

Part of #375.

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #434 (79f5e19) into nullsafety (4502f77) will increase coverage by 0.10%.
The diff coverage is 94.82%.

Impacted file tree graph

@@              Coverage Diff               @@
##           nullsafety     #434      +/-   ##
==============================================
+ Coverage       82.75%   82.86%   +0.10%     
==============================================
  Files              68       68              
  Lines            1653     1663      +10     
==============================================
+ Hits             1368     1378      +10     
  Misses            285      285              
Flag Coverage Δ
floor 82.86% <94.82%> (+0.10%) ⬆️
floor_generator 82.68% <94.82%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...loor_generator/lib/misc/annotation_expression.dart 100.00% <ø> (ø)
...enerator/lib/misc/change_method_writer_helper.dart 100.00% <ø> (ø)
...ator/lib/misc/extension/dart_object_extension.dart 100.00% <ø> (ø)
...or/lib/misc/extension/list_equality_extension.dart 100.00% <ø> (ø)
...tor/lib/misc/extension/set_equality_extension.dart 100.00% <ø> (ø)
...or_generator/lib/misc/extension/set_extension.dart 100.00% <ø> (ø)
...sc/extension/type_converter_element_extension.dart 100.00% <ø> (ø)
floor_generator/lib/misc/string_utils.dart 100.00% <ø> (ø)
floor_generator/lib/misc/type_utils.dart 100.00% <ø> (ø)
floor_generator/lib/processor/dao_processor.dart 100.00% <ø> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4502f77...aafe99f. Read the comment docs.

@vitusortner vitusortner marked this pull request as ready for review November 21, 2020 00:17
@vitusortner vitusortner merged commit 031ae5f into nullsafety Nov 21, 2020
@vitusortner vitusortner deleted the generator-null-safety-migration branch November 21, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant