Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Dart core types in Query return type. #691

Merged

Conversation

dkaera
Copy link
Collaborator

@dkaera dkaera commented Aug 14, 2022

Implemented basic logic to support Dart core types for returning in Query methods.

@dkaera dkaera marked this pull request as ready for review August 19, 2022 17:03
@dkaera dkaera requested review from mqus, ThomasMiddel and vitusortner and removed request for mqus and ThomasMiddel August 19, 2022 17:03
@dkaera dkaera enabled auto-merge (squash) August 19, 2022 17:03
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #691 (9c8da43) into develop (3d6b9a1) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #691      +/-   ##
===========================================
+ Coverage    90.57%   90.76%   +0.19%     
===========================================
  Files           10       11       +1     
  Lines          191      195       +4     
===========================================
+ Hits           173      177       +4     
  Misses          18       18              
Flag Coverage Δ
floor 90.76% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
floor/lib/src/adapter/query_adapter.dart 95.23% <100.00%> (+0.23%) ⬆️
floor/lib/src/util/string_utils.dart 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dkaera dkaera force-pushed the feature/support_dart_core_type_in_dao branch from aac19ef to 314f431 Compare August 23, 2022 09:38
ThomasMiddel
ThomasMiddel previously approved these changes Aug 31, 2022
Copy link
Contributor

@ThomasMiddel ThomasMiddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor remark, really nice job @dkaera 🙌

README.md Outdated Show resolved Hide resolved
ThomasMiddel
ThomasMiddel previously approved these changes Sep 6, 2022
memoriasIT
memoriasIT previously approved these changes Sep 16, 2022
Copy link

@memoriasIT memoriasIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits but LGTM

docs/daos.md Outdated Show resolved Hide resolved
docs/daos.md Outdated Show resolved Hide resolved
@dkaera dkaera dismissed stale reviews from memoriasIT and ThomasMiddel via 03d1290 September 28, 2022 08:08
@dkaera dkaera force-pushed the feature/support_dart_core_type_in_dao branch from 03d1290 to a578daa Compare September 28, 2022 08:21
@ThomasMiddel ThomasMiddel merged commit e4e3d10 into pinchbv:develop Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants