-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Dart core types in Query return type. #691
Allow Dart core types in Query return type. #691
Conversation
…rt_dart_core_type_in_dao
Codecov Report
@@ Coverage Diff @@
## develop #691 +/- ##
===========================================
+ Coverage 90.57% 90.76% +0.19%
===========================================
Files 10 11 +1
Lines 191 195 +4
===========================================
+ Hits 173 177 +4
Misses 18 18
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aac19ef
to
314f431
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor remark, really nice job @dkaera 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits but LGTM
03d1290
03d1290
to
a578daa
Compare
…rt_dart_core_type_in_dao
Implemented basic logic to support Dart core types for returning in Query methods.