-
Notifications
You must be signed in to change notification settings - Fork 3
md-04 - intelligent index creation with automatic value inference #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # internal/pkg/cli/command/index/create.go
There are some interesting ideas in here, but I'm sorry to say this is not ready to be reviewed in its current state. Each of your 8 bullet points is a different feature and in order to give them a proper review they should be in small, focused PRs that deal with each feature in isolation. It's not feasible for anyone to test a change and make sure all edge cases are properly handled when you have edits touching so many files at once in one diff. If we gave you feedback and you made changes, it would also be extremely cumbersome to re-review because of the massive volume of change. More important than these logistics of large diffs, it's simply not productive to argue back and forth in github comments about areas of disagreement that are mixed in with less complex and less controversial work that could otherwise be reviewed and merged much more quickly. Bundling everything together creates unnecessary coupling when many of these ideas can stand on their own. Things that seem totally non-controversial to me that you could break out:
Probably also a good idea:
Things I fundamentally disagree with and don't think are a good fit:
Product ideas that need more discussion, refinement, and prioritization before implementation:
|
Problem
The index creation process was complex and required users to manually specify many configuration parameters. It also required users to know the interdependencies between different flags, making it difficult for new users to get started quickly. There was no way to discover available embedding models, and users had to know the exact model names and their requirements. Additionally, there was no global option to skip confirmation prompts, making automation and scripting cumbersome.
Solution
This PR introduces intelligent index creation with automatic value inference and comprehensive model management capabilities. The changes include:
pc models
command to list available embedding models with their specifications and requirements--assume-yes
Flag: Added-y
/--assume-yes
global flag to skip all confirmation prompts for automation and scriptingThe implementation maintains full backward compatibility while significantly improving the user experience for both beginners and advanced users.
Type of Change
Test Plan
Model Discovery Testing: Test the new models command:
Intelligent Index Creation Testing: Test automatic value inference:
Global Assume-Yes Flag Testing: Test automation-friendly behavior:
Validation Testing: Test improved validation and error handling:
Backward Compatibility Testing: Ensure existing commands still work:
# Test explicit configuration (should work as before) pc index create my-index --dimension 1536 --metric cosine --cloud aws --region us-east-1
This PR builds upon the previous #36 style improvements and contains all changes in that branch as well