-
Notifications
You must be signed in to change notification settings - Fork 3
md-06 - backup commands #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azzazzel
wants to merge
35
commits into
pinecone-io:main
Choose a base branch
from
azzazzel:md-06
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # internal/pkg/cli/command/index/create.go
…esenters and error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The CLI lacked comprehensive backup management capabilities, which are essential for data protection and disaster recovery workflows. Additionally, collection commands were using inconsistent styling, validation, and error handling compared to the improved index commands. The error handling system was also limited to index-specific operations, making it difficult to provide consistent user-friendly error messages across all commands.
Solution
This PR introduces complete backup management functionality and unifies the styling, validation, and error handling across all vector database commands. The changes include:
HandleIndexAPIError
toHandleAPIError
for consistent user-friendly error messages across all commandsThe implementation ensures a consistent user experience across all vector database operations while providing essential backup management capabilities for production environments.
Type of Change
Test Plan
Backup Management Testing: Test all backup operations:
Collection Command Testing: Test updated collection commands with unified styling:
# Test collection operations with new styling pc collection list pc collection describe my-collection pc collection create --name my-collection --source my-pod-index pc collection delete my-collection
Error Handling Testing: Test consistent error handling across all commands:
Positional Arguments Testing: Test positional argument usage:
Styling Consistency Testing: Verify consistent styling across all commands:
Integration Testing: Test backup and collection commands with other features:
This PR enhances the vector database management capabilities by adding essential backup functionality while ensuring a consistent and polished user experience across all commands. It builds on top of #38 and contains all the changes from the previous branches in the series.