-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralize Go test suite #48
Changes from 25 commits
fbe03b0
58a7f90
b999395
3d551e4
317a661
8016f9d
17e7f35
e7d8985
146d041
4d87263
f270ea4
f4bf712
ff07545
80d338b
3994fa1
e8d814e
b59874b
7cd2da1
9b086f4
1aadcdb
eab6b0b
ce7cd8b
e3aa2bf
ac4d29d
e46d008
5bdf6d0
5630a58
600c06b
8b79a56
b91dfa9
cf5d0eb
517e8ed
bc8a4f5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1 @@ | ||
PINECONE_API_KEY="<Project API Key>" | ||
TEST_PODS_INDEX_NAME="<Pod based Index name>" | ||
TEST_SERVERLESS_INDEX_NAME="<Serverless based Index name>" | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,8 +17,7 @@ jobs: | |
run: | | ||
go get ./pinecone | ||
- name: Run tests | ||
run: go test ./pinecone | ||
# run: go test -count=1 -v ./pinecone | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We will re-enable this (and remove the line below) once the tests for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it make sense to just do that in this PR as well rather than having tests commented out between cycles? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah -- lemme rebase your changes (where you added the new env vars for the |
||
run: go test -count=1 -v -run IndexConnection ./pinecone | ||
env: | ||
TEST_PODS_INDEX_NAME: ${{ secrets.TEST_PODS_INDEX_NAME }} | ||
TEST_SERVERLESS_INDEX_NAME: ${{ secrets.TEST_SERVERLESS_INDEX_NAME }} | ||
PINECONE_API_KEY: ${{ secrets.API_KEY }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,9 +10,11 @@ | |
Official Pinecone Go Client | ||
|
||
## Documentation | ||
|
||
To see the latest documentation on `main`, visit https://pkg.go.dev/github.com/pinecone-io/go-pinecone@main/pinecone. | ||
|
||
To see the latest versioned-release's documentation, visit https://pkg.go.dev/github.com/pinecone-io/go-pinecone/pinecone. | ||
To see the latest versioned-release's documentation, | ||
visit https://pkg.go.dev/github.com/pinecone-io/go-pinecone/pinecone. | ||
|
||
## Features | ||
|
||
|
@@ -101,7 +103,7 @@ Then, execute `just bootstrap` to install the necessary Go packages | |
### .env Setup | ||
|
||
To avoid race conditions or having to wait for index creation, the tests require a project with at least one pod index | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: I think we can remove this whole first part since it's not longer true that we're avoiding waiting for indexes to create. |
||
and one serverless index. Copy the api key and index names to a `.env` file. See `.env.example` for a template. | ||
and one serverless index. Copy the api key to a `.env` file. See `.env.example` for a template. | ||
|
||
### API Definitions submodule | ||
|
||
|
@@ -111,7 +113,8 @@ The API Definitions are in a private submodule. To checkout or update the submod | |
git submodule update --init --recursive | ||
``` | ||
|
||
For working with submodules, see the [Git Submodules](https://git-scm.com/book/en/v2/Git-Tools-Submodules) documentation. | ||
For working with submodules, see the [Git Submodules](https://git-scm.com/book/en/v2/Git-Tools-Submodules) | ||
documentation. | ||
|
||
### Just commands | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
package pinecone | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this can be removed, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (I know this file is renamed, but answering anyways -- apparently no it needs to be there (says my IDE)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buh bai
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋