Skip to content

Remove urllib3 info from useragent string #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

jhamon
Copy link
Collaborator

@jhamon jhamon commented Apr 24, 2025

Problem

  • Currently we send urllib3 version in the user agent string
  • Testing with importtime shows importing urllib3 just to get the version extends the initial load time of the pinecone package by about 35 milliseconds.

Solution

I confirmed we're not using this information in the header, so we should remove it to improve initialization performance.

Test Plan

  • Analysis with showed Loading this urllib3 to get the version was adding 35 milliseconds to the time needed to "from pinecone import Pinecone"
  • Updated unit tests

@jhamon
Copy link
Collaborator Author

jhamon commented Apr 25, 2025

I'm merging this with failures; failing tests are unrelated and I've filed a bug with the backend team.

@jhamon jhamon marked this pull request as ready for review April 25, 2025 17:50
@jhamon jhamon merged commit d43373f into release-candidate/2025-04 Apr 25, 2025
52 of 56 checks passed
@jhamon jhamon deleted the jhamon/adjust-useragent branch April 25, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant