Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hydra for configs #299

Closed
ssenan opened this issue Jul 30, 2024 · 5 comments
Closed

Use hydra for configs #299

ssenan opened this issue Jul 30, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request stale
Milestone

Comments

@ssenan
Copy link
Collaborator

ssenan commented Jul 30, 2024

No description provided.

@ssenan ssenan added the enhancement New feature or request label Jul 30, 2024
@ssenan ssenan added this to the 0.1.0 milestone Jul 30, 2024
@ssenan ssenan self-assigned this Jul 30, 2024
@cameronraysmith
Copy link
Collaborator

cameronraysmith commented Jul 30, 2024

We can use the rebased version of #274, which adds this.

@cameronraysmith cameronraysmith mentioned this issue Jul 30, 2024
2 tasks
@ssenan
Copy link
Collaborator Author

ssenan commented Jul 30, 2024

@cameronraysmith I was actually thinking of going back to using plain hydra rather than hydra-zen since I find it a little more intuitive. I can put a preliminary structure together and integrate it with your workflow cli.

@cameronraysmith
Copy link
Collaborator

cameronraysmith commented Jul 30, 2024

Sure, we can easily use them together. In that case, I'd recommend just adding your intended support for non-hydra-zen hydra in a separate PR and I'll rebase #274 on it to make sure they won't conflict with each other. I unlinked #274 from this issue.

cli mapping to base/overridable configs

there can initially/eventually be a dnadiffusion cli command that points to regular hydra and something else like dnadiffusionzen that points to the hydra-zen version

it's not straightforward to integrate hydra and (rich-)click, but if that eventually works they could become command (sub)groups

  • dnadiffusion hydra ...
  • dnadiffusion zen ...

which would be much nicer, but is more complex to set up

for your PR, I don't even think there needs to necessarily even be a named cli script at all unless you want to include it

Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Sep 29, 2024
Copy link

github-actions bot commented Oct 7, 2024

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
Status: Done
Development

No branches or pull requests

2 participants