-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing datetimes with timezone not specified #17
base: main
Are you sure you want to change the base?
Conversation
Hi, I need this fix, can you kindly show me how I can implement this in my plugin or how do I download your version? Thanks so much before. |
The "plugin" is just a zip file containing the contents of the repo's |
Got this error message:
|
Seems like you might be using the repo zip directly, you do need to unzip that and re-zip it as noted in my comment above. Once unzipped, go into the |
Thanks finally managed to make it work. Hopefully @ping would come by soon and implement the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes fix the reported issue.
This is an unofficial release. Changes: - Fix: Uses libbyapp.com domain rather than svc.overdrive.com which fixes ping#33 - Fix: Applied spicefather's fix for date time formats (see ping#17) Also includes unreleased changes by ping including the following - New: Rename a card - Fix: Use a regex validator instead of input mask for Libby setup code due to wonkiness, ref ping#14
Some books include datetimes in their metadata without a timezone specified, causing the plugin to fail to download them with the following log:
This change allows parsing these datetimes as though they are UTC.