Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Record 7.0.1 or higher is required #45

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Active Record 7.0.1 or higher is required #45

merged 2 commits into from
Mar 31, 2022

Conversation

yahonda
Copy link
Member

@yahonda yahonda commented Mar 31, 2022

This pull request bumps the required Active Record version to 7.0.1 or higher
because of these two reasons:

I do not think we need to support Rails 7.0.0 for now.

rails/rails#44040 has been backported
to 7-0-stable branch via rails/rails@bed85678aaa,
which is included in Rails 7.0.1 or higher

12e5ef6
@yahonda yahonda requested a review from hooopo March 31, 2022 04:15
@yahonda
Copy link
Member Author

yahonda commented Mar 31, 2022

Disabled bundler cache at CI to address these errors.

https://github.com/pingcap/activerecord-tidb-adapter/runs/5765247683?check_suite_focus=true#step:4:32

  Found cache for key: setup-ruby-bundler-cache-v3-ubuntu-20.04-ruby-2.7.5-Gemfile.lock-cae623a9e50bc77a0bbd09c31968958c88cfd881f1feba9ab3004c584729e2e7
  /opt/hostedtoolcache/Ruby/2.7.5/x64/bin/bundle install --jobs 4
  You are trying to install in deployment mode after changing
  your Gemfile. Run `bundle install` elsewhere and add the
  updated Gemfile.lock to version control.
  
  If this is a development machine, remove the
  /home/runner/work/activerecord-tidb-adapter/activerecord-tidb-adapter/Gemfile
  freeze
  by running `bundle config unset deployment`.
  
  The gemspecs for path gems changed
  Took   7.13 seconds

@yahonda yahonda mentioned this pull request Mar 31, 2022
4 tasks
@hooopo hooopo merged commit 5287368 into pingcap:7-0-stable Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants