Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some mistakes in async commit article #579

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix some mistakes in async commit article #579

wants to merge 3 commits into from

Conversation

sticnarf
Copy link
Contributor

This PR fixes some mistakes according to readers' feedbacks.

Comment on the first change:
I suggest changing the min commit TS constraint to be PD TS + 1. It gives a strict order between the transactions. The current implementation is actually OK because no order reverse can be observed but it feels logically strange.

cc @youjiali1995

@sticnarf sticnarf mentioned this pull request May 12, 2021
Merged
sticnarf and others added 2 commits May 17, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youjiali1995 youjiali1995 youjiali1995 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sticnarf @youjiali1995