This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
collector: remove cputime (#970) #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/lgtm |
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 973ac3d
|
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/merge |
|
/merge |
|
/run-all-tests |
|
/build |
|
/run-check-release-note |
This was referenced Apr 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #970 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr https://github.com/pingcap/br/pull/1009After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
solved #960
What is changed and how it works?
remove the CPU time recorded in summary.
At the same time, fix mis-collected checksum time collection, and put all summary info to zap log fields.
Check List
Tests
Simple restore log:
[2021/03/31 05:09:03.162 +00:00] [INFO] [collector.go:61] ["Full restore success summary"] [total-ranges=15] [ranges-succeed=15] [ranges-failed=0] [split-region=69.741025ms] [restore-checksum=36.549082ms] [restore-ranges=9] [Size=2697339] [total-take=3.064856286s] [total-kv=9000] [total-size=3.849MB] [average-speed=40.52MB/s]Release Note