Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: fix wrong error message of restoring table #1049

Merged
merged 4 commits into from
Apr 26, 2021
Merged

lightning: fix wrong error message of restoring table #1049

merged 4 commits into from
Apr 26, 2021

Conversation

Abingcbc
Copy link
Contributor

What problem does this PR solve?

Restoring table schema raised wrong error messages.
#969

What is changed and how it works?

Propagating the error out.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

Release Note

  • No release note

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Member

Welcome @Abingcbc!

It looks like this is your first PR to pingcap/br 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/br. 😃

@ti-chi-bot ti-chi-bot requested review from kennytm and YuJuncen April 24, 2021 10:17
@kennytm
Copy link
Collaborator

kennytm commented Apr 24, 2021

/build

@glorv glorv changed the title fix(lightning): wrong error message of restoring table lightning: fix wrong error message of restoring table Apr 25, 2021
glorv
glorv reviewed Apr 25, 2021
View reviewed changes
Copy link
Collaborator

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM, thank you~

pkg/lightning/mydump/loader_test.go Outdated Show resolved Hide resolved
@glorv
Copy link
Collaborator

glorv commented Apr 26, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Apr 26, 2021
@3pointer
Copy link
Collaborator

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Apr 26, 2021
@glorv
Copy link
Collaborator

glorv commented Apr 26, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b66cc9d

@glorv
Copy link
Collaborator

glorv commented Apr 26, 2021

/build

@kennytm
Copy link
Collaborator

kennytm commented Apr 26, 2021

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit b09611d into pingcap:master Apr 26, 2021
ti-srebot pushed a commit to ti-srebot/br that referenced this pull request Apr 26, 2021
@Abingcbc @ti-srebot
cherry pick pingcap#1049 to release-4.0
37a7a55 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #1064

ti-srebot pushed a commit to ti-srebot/br that referenced this pull request Apr 26, 2021
@Abingcbc @ti-srebot
cherry pick pingcap#1049 to release-5.0
f03736c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #1065

ti-chi-bot pushed a commit that referenced this pull request Apr 30, 2021
@ti-srebot
lightning: fix wrong error message of restoring table (#1049) (#1064)
1367604
ti-chi-bot pushed a commit that referenced this pull request May 27, 2021
@ti-srebot
lightning: fix wrong error message of restoring table (#1049) (#1065)
079faaf
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@glorv glorv glorv left review comments

@kennytm kennytm Awaiting requested review from kennytm

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

Assignees
No one assigned
Labels
component/import contribution first-time-contributor needs-cherry-pick-release-4.0 needs-cherry-pick-release-5.0 size/M status/can-merge status/LGT2 LGTM2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Abingcbc @CLAassistant @ti-chi-bot @kennytm @glorv @3pointer @ti-srebot